refactor: Adjust text resource input component for input table #14151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
solution/studio/designer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14151 +/- ##
=======================================
Coverage 95.45% 95.46%
=======================================
Files 1803 1803
Lines 23494 23505 +11
Branches 2719 2719
=======================================
+ Hits 22427 22438 +11
Misses 813 813
Partials 254 254 ☔ View full report in Codecov by Sentry. |
TomasEng
changed the title
TomasEng
force-pushed
the
adjust-text-resource-component-for-input-table
branch
from
312c300 to
c3b9799
Compare
TomasEng
changed the title
TomasEng
added
skip-releasenotes
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
TomasEng
force-pushed
the
adjust-text-resource-component-for-input-table
branch
from
c3b9799 to
5adbb9b
Compare
standeren
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Vanskelig å finne noe å ta tak i her! 🤩
I tillegg til de ubetydelige kommentarene mine, som du bare må lukke om du ikke ønsker å ta stilling til, så tenkte jeg bare å informere om at når jeg åpner koden i Rider hos meg så får jeg masse typefeil som dette:
Type Element is not assignable to type
ReactElement<any, string | JSXElementConstructor<any>
og
Type Element is not assignable to type
string | number | boolean | ReactElement<any, string | JSXElementConstructor<any>> | Iterable<ReactNode> | ReactPortal
Property children is missing in type Element but required in type ReactPortal
index.d.ts(378, 9): children is declared here
Godt mulig det bare er typescript som ikke er konfigurert godt nok hos meg tho.
EDIT: Måtte oppdatere Rider 😉
...nd/libs/studio-components/src/components/StudioTextResourceInput/StudioTextResourceInput.tsx
Show resolved
Hide resolved
...nd/libs/studio-components/src/components/StudioTextResourceInput/StudioTextResourceInput.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
StudioInputTablecomponent reqiures its subcomponents to forward refs and to accept native props for input elements. It will also be necessary to set a class name for the different subcomponents ofStudioTextResourceInput. This pull request adds this functionality to theStudioTextResourceInputcomponent, so that we can create aStudioInputTable.Cell.TextResourcecomponent from it.Related Issue(s)
Verification